Correct FspInfoheader Assumption #10678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
AshrafAliS,
cbduggap,
ChaselChiu,
lzeng14,
nate-desimone and
tedkuo1
praravin
force-pushed
the
correct_fspinfoheader_assumption
branch
from
37e78bd to
4234dce
Compare
AshrafAliS
reviewed
Jan 27, 2025
| ; | ||
| CALL_RDI ASM_PFX(AsmGetFspInfoHeaderNoStack) | ||
| xor rsi, rsi | ||
| mov rsi, rax |
| ; Get FspInfoHeader address | ||
| ; | ||
| CALL_RDI ASM_PFX(AsmGetFspInfoHeaderNoStack) | ||
| xor rsi, rsi |
There was a problem hiding this comment.
do we need the xor operation?
There was a problem hiding this comment.
removed as it is not necessary
praravin
force-pushed
the
correct_fspinfoheader_assumption
branch
from
4234dce to
438cc3a
Compare
praravin
force-pushed
the
correct_fspinfoheader_assumption
branch
3 times, most recently
from
d0a92b1 to
7ef43c7
Compare
AshrafAliS
approved these changes
Jan 30, 2025
tedkuo1
reviewed
Feb 3, 2025
| ; | ||
| ; Get FspInfoHeader address | ||
| ; | ||
| CALL_EDI ASM_PFX(AsmGetFspInfoHeaderNoStack) |
There was a problem hiding this comment.
EAX holds FSP info header after LoadUpdPointerToECX called at line#602. We can save EAX to ESI at line#603 instead of calling AsmGetFspInfoHeaderNoStack here.
| ; | ||
| ; Get FspInfoHeader address | ||
| ; | ||
| CALL_RDI ASM_PFX(AsmGetFspInfoHeaderNoStack) |
There was a problem hiding this comment.
We can call AsmGetFspInfoHeaderNoStack and save RAX to RSI at line#450. By doing so, calling AsmGetFspInfoHeaderNoStack can be removed from line#460.
praravin
force-pushed
the
correct_fspinfoheader_assumption
branch
from
7ef43c7 to
b1884b1
Compare
It is assumed that the address of FspInfoheader is present in rsi while reading ImageAttribute. Reading and retrieving the FspInfoheader address to correct this. Signed-off-by: Aravind P R <[email protected]>
praravin
force-pushed
the
correct_fspinfoheader_assumption
branch
from
b1884b1 to
bff24b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is assumed that the address of FspInfoheader is present
in rsi while reading ImageAttirbute. Reading and retrieving
the FspInfoheader to correct this.
Signed-off-by: Aravind P R [email protected]
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>